Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RIR dominator graph pass #1354

Merged
merged 2 commits into from
Apr 3, 2024
Merged

RIR dominator graph pass #1354

merged 2 commits into from
Apr 3, 2024

Conversation

swernli
Copy link
Collaborator

@swernli swernli commented Apr 3, 2024

This introduces an RIR pass that builds the dominator graph for program, which will be used by later passes for checking validity of SSA and generating required phi nodes.

@swernli
RIR dominator graph pass
c7d48f0 
This introduces an RIR pass that builds the dominator graph for program, which will be used by later passes for checking validity of SSA and generating required phi nodes.
@swernli swernli mentioned this pull request Apr 3, 2024
Closed
64 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Benchmark for fc9ce1b

Click to view benchmark
Test Base PR %
Array append evaluation 343.4±2.40µs 344.1±1.71µs +0.20%
Array literal evaluation 195.4±0.95µs 202.0±3.38µs +3.38%
Array update evaluation 424.1±1.95µs 427.6±4.84µs +0.83%
Core + Standard library compilation 18.4±0.53ms 17.4±0.32ms -5.43%
Deutsch-Jozsa evaluation 5.2±0.05ms 5.1±0.04ms -1.92%
Large file parity evaluation 33.7±0.10ms 33.7±0.38ms 0.00%
Large input file compilation 11.9±0.29ms 11.6±0.18ms -2.52%
Large input file compilation (interpreter) 47.6±0.92ms 45.9±1.03ms -3.57%
Large nested iteration 33.6±0.34ms 33.6±0.24ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1517.3±74.77µs 1499.4±49.71µs -1.18%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.9±0.12ms 7.8±0.09ms -1.27%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1443.6±80.74µs 1418.1±57.34µs -1.77%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.8±0.20ms 21.6±0.50ms -0.92%
Teleport evaluation 81.1±3.55µs 81.4±4.30µs +0.37%

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Benchmark for c459f0a

Click to view benchmark
Test Base PR %
Array append evaluation 343.6±4.58µs 332.7±2.06µs -3.17%
Array literal evaluation 195.2±0.85µs 177.0±3.06µs -9.32%
Array update evaluation 424.2±3.06µs 413.8±2.97µs -2.45%
Core + Standard library compilation 16.8±0.04ms 16.7±0.30ms -0.60%
Deutsch-Jozsa evaluation 5.1±0.04ms 5.1±0.31ms 0.00%
Large file parity evaluation 33.7±0.18ms 33.5±0.09ms -0.59%
Large input file compilation 11.2±0.40ms 11.3±0.09ms +0.89%
Large input file compilation (interpreter) 43.5±1.18ms 43.5±1.50ms 0.00%
Large nested iteration 33.5±0.38ms 32.5±0.63ms -2.99%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1495.0±27.64µs 1494.8±28.11µs -0.01%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.7±0.08ms 7.6±0.07ms -1.30%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1409.1±30.85µs 1412.3±27.57µs +0.23%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.2±0.19ms 21.3±0.16ms +0.47%
Teleport evaluation 83.2±8.78µs 81.1±4.85µs -2.52%

@swernli swernli added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 2b393d2 Apr 3, 2024
16 checks passed
@swernli swernli deleted the swernli/dominator-graph branch April 3, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idavis idavis idavis approved these changes

@cesarzc cesarzc Awaiting requested review from cesarzc cesarzc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swernli @idavis